[Sources] Message links like https://t.me/channel/451 are accepted but fail to index #10

New issue

Closed

opened 2026-08-23 19:08:35 +02:00 by vmruiz · 1 comment

vmruiz commented 2026-08-23 19:08:35 +02:00

Owner

Copy link

Current behaviour

The "Telegram chat" field in the Sources form (add-source dialog) accepts message links such as https://t.me/telegram/451 or https://t.me/somechannel/12345. These pass through _normalize_telegram_chat_identifier() unchanged because telethon.utils.parse_username does not recognise the t.me/<channel>/<message_id> shape (it returns (None, False)), so the value is stored verbatim as the Source.telegram_chat.

At indexing time, _resolve_chat() (app/telegram/indexer.py) calls client.get_entity("https://t.me/telegram/451"), which raises ValueError and the source never indexes.

Verified on current code:

>>> _normalize_telegram_chat_identifier("https://t.me/telegram/451")
"https://t.me/telegram/451"
>>> utils.parse_username("https://t.me/telegram/451")
(None, False)

So the message-link shape is neither normalised to a channel nor rejected - it silently becomes a source that can never be indexed.

Desired behaviour

Either:

1. Reject message links at creation time with a clear error (e.g. "Telegram message links are not supported; use the channel link https://t.me/ or @username"), OR
2. Accept and clean them - strip the trailing /<message_id> segment and keep only the channel part, so https://t.me/telegram/451 is stored as @telegram and indexes normally.

Option 2 is the more forgiving UX and reuses the existing normaliser, but it should be a deliberate choice. Either way, the stored value must always be a shape _resolve_chat understands (@username, numeric id, or t.me/+invite).

Related

Introduced alongside the t.me link support in PR #9 / issue #4 - that only handled t.me/<username> channel links and t.me/+invite invite links, not t.me/<username>/<message_id> message links.

## Current behaviour The "Telegram chat" field in the Sources form (add-source dialog) accepts message links such as `https://t.me/telegram/451` or `https://t.me/somechannel/12345`. These pass through `_normalize_telegram_chat_identifier()` unchanged because `telethon.utils.parse_username` does not recognise the `t.me/<channel>/<message_id>` shape (it returns `(None, False)`), so the value is stored verbatim as the `Source.telegram_chat`. At indexing time, `_resolve_chat()` (app/telegram/indexer.py) calls `client.get_entity("https://t.me/telegram/451")`, which raises ValueError and the source never indexes. Verified on current code: ```python >>> _normalize_telegram_chat_identifier("https://t.me/telegram/451") "https://t.me/telegram/451" >>> utils.parse_username("https://t.me/telegram/451") (None, False) ``` So the message-link shape is neither normalised to a channel nor rejected - it silently becomes a source that can never be indexed. ## Desired behaviour Either: 1. Reject message links at creation time with a clear error (e.g. "Telegram message links are not supported; use the channel link https://t.me/<channel> or @username"), OR 2. Accept and clean them - strip the trailing /<message_id> segment and keep only the channel part, so `https://t.me/telegram/451` is stored as `@telegram` and indexes normally. Option 2 is the more forgiving UX and reuses the existing normaliser, but it should be a deliberate choice. Either way, the stored value must always be a shape `_resolve_chat` understands (@username, numeric id, or t.me/+invite). ## Related Introduced alongside the t.me link support in PR #9 / issue #4 - that only handled `t.me/<username>` channel links and `t.me/+invite` invite links, not `t.me/<username>/<message_id>` message links.

vmruiz referenced this issue from a commit 2026-08-23 19:24:30 +02:00

fix(sources): normalise t.me message links to their chat (refs #10)

vmruiz referenced this issue from a pull request that will close it, 2026-08-23 19:24:50 +02:00

fix(sources): normalise t.me message links to their chat #11

vmruiz referenced this issue from a commit 2026-08-23 19:39:16 +02:00

ci: comment the preview endpoint on issues referenced by HEAD commit (refs #10)

vmruiz referenced this issue from a commit 2026-08-23 19:49:01 +02:00

ci: fix workflow validation and post preview comment only once (refs #10)

forgejo-actions commented 2026-08-23 19:49:42 +02:00

Copy link

Branch preview deployed by CI.

• Branch: fix/message-link-normalise
• Commit: df887fbee0121bcd0d820cd34870d90b352a983d
• Endpoint: https://telegramarr-cb9f9f5d5.celor.es/

Auto-generated by .forgejo/workflows/dev-deploy.yml.

Branch preview deployed by CI. - Branch: `fix/message-link-normalise` - Commit: `df887fbee0121bcd0d820cd34870d90b352a983d` - Endpoint: https://telegramarr-cb9f9f5d5.celor.es/ _Auto-generated by `.forgejo/workflows/dev-deploy.yml`._

vmruiz closed this issue 2026-08-23 20:40:41 +02:00

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

feat/first-run-setup

chore/docker-image-size

fix/message-link-normalise

feat/issue-4-tme-link

fix/library-infinite-scroll

feat/seed-demo

feat/thumbnail-recovery-jobs

fix/library-filtering

v0.1.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

vmruiz/telegramarr#10

No description provided.